[ 
https://issues.apache.org/jira/browse/TINKERPOP-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959039#comment-15959039
 ] 

ASF GitHub Bot commented on TINKERPOP-1438:
-------------------------------------------

Github user pluradj commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/569#discussion_r109934781
  
    --- Diff: docs/src/reference/gremlin-applications.asciidoc ---
    @@ -1075,6 +1075,7 @@ The following table describes the various 
configuration options that Gremlin Ser
     |authentication.className |The fully qualified classname of an 
`Authenticator` implementation to use.  If this setting is not present, then 
authentication is effectively disabled. |`AllowAllAuthenticator`
     |authentication.config |A `Map` of configuration settings to be passes to 
the `Authenticator` when it is constructed.  The settings available are 
dependent on the implementation. |_none_
     |channelizer |The fully qualified classname of the `Channelizer` 
implementation to use.  A `Channelizer` is a "channel initializer" which 
Gremlin Server uses to define the type of processing pipeline to use.  By 
allowing different `Channelizer` implementations, Gremlin Server can support 
different communication protocols (e.g. Websockets, Java NIO, etc.). 
|`WebSocketChannelizer`
    +|graphManager |The fully qualified classname of the `GraphManager` 
implementation to use.  A `GraphManager` is a class that adheres to the 
Tinkerpop `GraphManager` interface, allowing custom implementations for storing 
and managing graph references, as well as defining custom methods to open and 
close graphs instantiations. It is important to note that the Tinkerpop Http 
and WebSocketChannelizers auto-commit and auto-rollback based on the graphs 
stored in the graphManager upon script execution completion. 
|`DefaultGraphManager`
    --- End diff --
    
    TinkerPop -- can fix case on commit


> Consider GraphManager as an interface
> -------------------------------------
>
>                 Key: TINKERPOP-1438
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1438
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.2.2
>            Reporter: stephen mallette
>            Priority: Minor
>              Labels: breaking
>
> If {{GraphManager}} were an interface it would make embedding Gremlin Server 
> easier as {{Graph}} instances could be more easily supplied by the host 
> application. In doing this, It also might be good to force a 
> {{TraversalSource}} to be referred to by both the {{Graph}} name and  
> {{TraversalSource}} name.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to