[
https://issues.apache.org/jira/browse/TINKERPOP-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049378#comment-16049378
]
Florian Hockmann commented on TINKERPOP-1552:
---------------------------------------------
{quote}
it would be nice to have some more legit code documentation across the board in
gremlin-dotnet
{quote}
I think that I commented everything that is visible to users except for the
auto-generated part. It would of course be great to also copy the comments from
the Java steps to the generated C# steps in the long run.
Regarding parts that are only visible internally: I prefer not to comment them
if it isn't really necessary as those comments tend to get outdated as you have
to remember to always change them when you change the code. In addition to that
I hope that everything in Gremlin.Net has a name that reveals its purpose so
that a comment shouldn't be necessary (or helpful).
But if you think otherwise then I'll add more comments.
{quote}
if you feel like making that change I can get it merged.
{quote}
Ok, I will create a pull request for that. Apart from that we should now only
have to update the information for the NuGet package and then we can publish a
first pre-release version. Could you create an account on nuget.org for Apache
TinkerPop? Then I can add it as an owner of Gremlin.Net.
> C# Gremlin Language Variant
> ---------------------------
>
> Key: TINKERPOP-1552
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1552
> Project: TinkerPop
> Issue Type: Improvement
> Components: language-variant
> Affects Versions: 3.2.3
> Reporter: Jorge Bay
> Assignee: stephen mallette
>
> It would be nice to have a C# GLV that runs under .NET Framework 4.5+ and
> .NET Core.
> The maven build could use the Exec Maven Plugin to exec .NET Core's [dotnet
> test|https://www.microsoft.com/net/core#macos] command.
> Some requirements, from the mailing list (edited):
> {quote}
> 1. The GLV should keep in line with class/method names of the java API
> where possible to ensure consistency of feel across languages.
> 2. There needs to be adequate tests (we're still discussing the approach to
> testing GLVs and i think that needs to be tackled sooner than later as more
> GLVs start to come in). Those tests should produce xunit style output
> unless there is some good reason not to.
> 3. There needs to be adequate documentation (e.g. Reference docs)
> 4. The build/deploy process needs to be bound to maven which might be one of
> the trickier bits to deal with.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
