[ 
https://issues.apache.org/jira/browse/TINKERPOP-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16047031#comment-16047031
 ] 

ASF GitHub Bot commented on TINKERPOP-1552:
-------------------------------------------

GitHub user FlorianHockmann opened a pull request:

    https://github.com/apache/tinkerpop/pull/625

    TINKERPOP-1552: Add support for authentication (Plain SASL) to Gremlin.Net

    https://issues.apache.org/jira/browse/TINKERPOP-1552
    
    This adds support for authentication with Plain SASL (username + password) 
to the Gremlin.Net driver. The functionality was originally implemented for the 
pre-GLV version of Gremlin.Net by @TigerSun-MS from the @CosmosDB team (see 
FlorianHockmann/Gremlin.Net#7).
    
    The Gremlin Server instance used for the authentication related integration 
tests complains during startup about some duplicate metric name, but everything 
works as expected and all tests pass. This is the beginning of the stack trace:
    
    ```
    [WARNING] Could not initialize gremlin-groovy GremlinScriptEngine as init 
script could not be evaluated
    java.lang.IllegalArgumentException: A metric named 
org.apache.tinkerpop.gremlin.server.GremlinServer.gremlin-groovy.sessionless.class-cache.long-run-compilation-count
 already exists
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/FlorianHockmann/tinkerpop 
dotnet-authentication

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/625.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #625
    
----
commit 64d2236a38f550e77fd7faae1638f5a83a516af4
Author: Florian Hockmann <f...@florian-hockmann.de>
Date:   2017-06-12T20:09:24Z

    Add support for authentication (Plain SASL) to Gremlin.Net

----


> C# Gremlin Language Variant
> ---------------------------
>
>                 Key: TINKERPOP-1552
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1552
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: language-variant
>    Affects Versions: 3.2.3
>            Reporter: Jorge Bay
>            Assignee: stephen mallette
>
> It would be nice to have a C# GLV that runs under .NET Framework 4.5+ and 
> .NET Core.
> The maven build could use the Exec Maven Plugin to exec .NET Core's [dotnet 
> test|https://www.microsoft.com/net/core#macos] command.
> Some requirements, from the mailing list (edited):
> {quote}
> 1. The GLV should keep in line with class/method names of the java API
> where possible to ensure consistency of feel across languages.
> 2. There needs to be adequate tests (we're still discussing the approach to
> testing GLVs and i think that needs to be tackled sooner than later as more
> GLVs start to come in). Those tests should produce xunit style output
> unless there is some good reason not to.
> 3. There needs to be adequate documentation (e.g. Reference docs)
> 4. The build/deploy process needs to be bound to maven which might be one of 
> the trickier bits to deal with.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to