Github user spmallette commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/631#discussion_r123512314
  
    --- Diff: 
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/structure/PropertyTest.java
 ---
    @@ -59,14 +59,40 @@
         public static class BasicPropertyTest extends AbstractGremlinTest {
             @Test
             @FeatureRequirementSet(FeatureRequirementSet.Package.VERTICES_ONLY)
    -        public void shouldHaveStandardStringRepresentation() {
    +        public void 
shouldHaveStandardStringRepresentationForVertexProperty() {
                 final Vertex v = graph.addVertex("name", "marko");
                 final Property p = v.property("name");
                 assertEquals(StringFactory.propertyString(p), p.toString());
             }
     
             @Test
             @FeatureRequirementSet(FeatureRequirementSet.Package.VERTICES_ONLY)
    +        public void 
shouldHaveTruncatedStringRepresentationForVertexProperty() {
    +            final Vertex v = graph.addVertex("name", "maria de la santa 
cruz rosalina agnelia rodriguez cuellar rene");
    +            final Property p = v.property("name");
    +            assertEquals(StringFactory.propertyString(p), p.toString());
    --- End diff --
    
    That test is more to validate that providers are using the `StringFactory` 
(or at least make their stuff align to `StringFactory` output).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to