[
https://issues.apache.org/jira/browse/TINKERPOP-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16059979#comment-16059979
]
ASF GitHub Bot commented on TINKERPOP-915:
------------------------------------------
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/618
The more i think about this the more I wonder if testing lots of server
configurations with the same scenarios is useful. Generally speaking the
`Channelizer` isn't responsible for many of the features under test in
`GremlinServerIntegrateTest` and there are other tests that are probably
testing `Channelizer` capabilities that aren't represented there (maybe more
true on master than tp32 - you might need a second PR when we sort this one
out).
I think it would be worth identifying the tests that validate that a
`Channelizer` is doing its job right and make a common set of tests that are
executed over different server configurations. This would probably mean cherry
picking tests from existing ones and moving them to this new test class.
For example, `shouldBatchResultsByTwos` has nothing to do with the
`Channelizer` selection really. That's an integration test for the
`OpProcessor` really. On a similar note,
`shouldReceiveFailureTimeOutOnScriptEval` is a integration test of the
`GremlinExecutor` - such a test would not need to be executed across multiple
configurations.
On the other hand, `shouldStartWithDefaultSettings` is quite generic and
would be a good general smoke test. That one could be cherry picked to the new
common test class and renamed to "shouldReturnListOfNumbers". We'd probably
also want to know if SSL/authentication can be enabled across all `Channelizer`
implementations - that's a common feature and one controlled by the
`Channelizer`.
Does that make sense to you at all?
> Gremlin Server supports REST and Websockets simultanteously
> -----------------------------------------------------------
>
> Key: TINKERPOP-915
> URL: https://issues.apache.org/jira/browse/TINKERPOP-915
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.0.2-incubating
> Reporter: stephen mallette
>
> Develop a {{Channelizer}} that allows REST and Websockets to be configured at
> the same time. I've personally tried to do this on a couple of attempts
> while following a Netty sample, but I've never been able to get it to work.
> Perhaps folks like [~pluradj] or [~dmill] would like to give it a go some
> day? :)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
