[
https://issues.apache.org/jira/browse/TINKERPOP-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16054644#comment-16054644
]
ASF GitHub Bot commented on TINKERPOP-915:
------------------------------------------
Github user krlohnes commented on the issue:
https://github.com/apache/tinkerpop/pull/618
My change can be summed up by
"Setup the WebSocket stuff and insert the `GremlinEndpointHandler` into the
`ChannelPipeline` to serve Http requests when necessary"
Changes to the `WebSocketChannelizer` and `SaslAuthenticationHandler` would
likely be picked up easily enough by simply using the combined channelizer. If
there was an issue with the `HttpChannelizer`, it may not be picked up by those
tests.
Running all of the tests from both was mostly for my own sanity. I wanted
to make sure I wasn't missing something.
If you're thinking about minimizing impact from extra tests running in the
TP suite, I'd probably suggest running the combined channelizer on WS tests and
both on `GremlinServerHttpIntegrateTest`.
> Gremlin Server supports REST and Websockets simultanteously
> -----------------------------------------------------------
>
> Key: TINKERPOP-915
> URL: https://issues.apache.org/jira/browse/TINKERPOP-915
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.0.2-incubating
> Reporter: stephen mallette
>
> Develop a {{Channelizer}} that allows REST and Websockets to be configured at
> the same time. I've personally tried to do this on a couple of attempts
> while following a Netty sample, but I've never been able to get it to work.
> Perhaps folks like [~pluradj] or [~dmill] would like to give it a go some
> day? :)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
