[ https://issues.apache.org/jira/browse/TINKERPOP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130700#comment-16130700 ]
ASF GitHub Bot commented on TINKERPOP-1489: ------------------------------------------- GitHub user jorgebay opened a pull request: https://github.com/apache/tinkerpop/pull/695 TINKERPOP-1489 JavaScript GLV https://issues.apache.org/jira/browse/TINKERPOP-1489 Submitting the JavaScript for review to merge into tp32 after 3.2.6 code freeze and release. Changes since #626: - Rebased. - Adapted code generation to use groovy templates (similar to #608 for Python). You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1489 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/695.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #695 ---- commit fbeae06cad99e4d3f5ce1f3f3fbe02641cb783d1 Author: Jorge Bay Gondra <jorgebaygon...@gmail.com> Date: 2016-10-05T14:14:46Z Javascript GLV commit ba0f0ac56c936ba848f7bbe460ae9772128f3ae1 Author: Jorge Bay Gondra <jorgebaygon...@gmail.com> Date: 2016-10-07T10:01:30Z Export enums and fix TraversalStrategies#applyStrategies() commit 673040d5d50e4619c375b1cbcc59e65c344a98c0 Author: Jorge Bay Gondra <jorgebaygon...@gmail.com> Date: 2016-10-18T14:22:23Z Graph, traversalStrategies and graph as Traversal properties Expose those properties as in the Python GLV and the Java implementation. Previously, those properties where exposed using the private notation (ie: _graph). commit 29f43b0344116d05e4d9b38a85acc73c203642a8 Author: Jorge Bay Gondra <jorgebaygon...@gmail.com> Date: 2016-10-19T14:03:45Z Filter out __() static method commit 3769fdd11a635894a53de53b16f32d164ca38c0d Author: Jorge Bay Gondra <jorgebaygon...@gmail.com> Date: 2016-11-03T13:34:28Z Use null as empty result commit 14c0209a514993ba706c30daccc3ea09527c014a Author: Jorge Bay Gondra <jorgebaygon...@gmail.com> Date: 2016-11-16T12:41:46Z Parse Edge and VertexProperty properties To follow the decision around TINKERPOP-1474 for the GLV to parse properties. commit eab70fdc0433ba540fc3a71afd4e651e43d92875 Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-05-18T16:47:48Z TINKERPOP-1489 Cleaned up pom Removed some weird characters in license and bumped version to 3.2.5-SNAPSHOT commit fdcc5affc37fae38c695439f2e973d9fcf436acb Author: Stephen Mallette <sp...@genoprime.com> Date: 2017-05-18T16:48:27Z TINKERPOP-1489 Regenerated traversal.js which added Pick. commit dfcb46f859c6b66e9a5f56a210a8148147de762e Author: Jorge Bay Gondra <jorgebaygon...@gmail.com> Date: 2017-06-06T13:05:14Z Update Javascript GLV Address feedback and provide maven integration: - Reorganize gremlin-javascript into node.js project - Simplify javascript code generators - Generate package.json to match project version - Introduce Promise factory for third-party promise library integration (ie: bluebird) - Use toList() and next() traversal methods - Include Remote connection implementation - Fix enum casing - Use Maven nodejs plugin - .gitignore and .npmignore at gremlin-javascript level - Run integration tests using a gremlin-server instance - Add gremlin-javascript doc in gremlin-variants.asciidoc commit 887d3ae9208eb62d5e9940d0b5976abceddd7271 Author: Jorge Bay Gondra <jorgebaygon...@gmail.com> Date: 2017-08-17T11:35:47Z Bump to 3.2.6 in gremlin-javascript commit 043be33f5ca878c94b6ad551b55bd9d280706024 Author: Jorge Bay Gondra <jorgebaygon...@gmail.com> Date: 2017-08-17T15:28:32Z Js GLV: Use Groovy templates for generation ---- > Provide a Javascript Gremlin Language Variant > --------------------------------------------- > > Key: TINKERPOP-1489 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1489 > Project: TinkerPop > Issue Type: Improvement > Components: language-variant > Affects Versions: 3.2.5 > Reporter: Jorge Bay > > It would be nice to have a Javascript Gremlin Language Variant that could > work with any ES5 runtime, specially the ones that support > [CommonJs|http://requirejs.org/docs/commonjs.html], like Node.js. > Nashorn, the engine shipped with JDK 8+, does not implement CommonJs but > provides [additional > extensions|https://wiki.openjdk.java.net/display/Nashorn/Nashorn+extensions] > making modular JavaScript possible. Nashorn should be supported in order to > run glv tests under the same infrastructure (JDK8). -- This message was sent by Atlassian JIRA (v6.4.14#64029)