[
https://issues.apache.org/jira/browse/TINKERPOP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158445#comment-16158445
]
ASF GitHub Bot commented on TINKERPOP-1489:
-------------------------------------------
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/695
I mostly cared about nashorn to achieve testing as we did in python. I
sense that most folks won't want to run on nashorn itself, so perhaps direct
support of nashorn doesn't really matter especially if we come up with a better
way to test. I'd rather not complicate gremlin-javascript with multiple
runtimes - GLVs require enough effort to support as it is.
btw, i felt like this lib got me pretty far in making npm work on nashorn:
https://github.com/nodyn/jvm-npm
wasn't too bad, but got tripped up on the pathing as it didn't seem to want
to run in a context that didn't have the js files in the same root directory as
where you were running the scriptengine from. I couldn't quite figure out how
to make that work. Again, it probably doesn't make sense to chase that angle
anymore though. I'd rather just get testing figured out for GLVs in general.
> We can define a set of given-when-then statements (in doc), which we can
make sure each GLV implements in actual tests.
if we can write them in a doc, then it would seem we could write them as
cucumber tests ( https://cucumber.io/ ) that could actually be executed
somehow. that's been the general plan i've had anyway. if you have any other
ideas, please let me know - i'll probably start playing around with this idea
today or get started on it fresh next week.
> Provide a Javascript Gremlin Language Variant
> ---------------------------------------------
>
> Key: TINKERPOP-1489
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1489
> Project: TinkerPop
> Issue Type: Improvement
> Components: language-variant
> Affects Versions: 3.2.5
> Reporter: Jorge Bay
>
> It would be nice to have a Javascript Gremlin Language Variant that could
> work with any ES5 runtime, specially the ones that support
> [CommonJs|http://requirejs.org/docs/commonjs.html], like Node.js.
> Nashorn, the engine shipped with JDK 8+, does not implement CommonJs but
> provides [additional
> extensions|https://wiki.openjdk.java.net/display/Nashorn/Nashorn+extensions]
> making modular JavaScript possible. Nashorn should be supported in order to
> run glv tests under the same infrastructure (JDK8).
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
