[
https://issues.apache.org/jira/browse/TINKERPOP-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175325#comment-16175325
]
ASF GitHub Bot commented on TINKERPOP-1789:
-------------------------------------------
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/720
TINKERPOP-1789: Reference elements should be represented by id and label
https://issues.apache.org/jira/browse/TINKERPOP-1789
Fixed a bug where `ReferenceVertex` was always returning an `EMPTY_STRING`
`label()`. `ReferenceEdge` and `ReferenceVertexProperty` were behaving
correctly, but I needed to make a change at `ReferenceElement` for general
handling of all element labels. Thus, those other two classes changed. And
thus, the Gryo. I updated all the `ReferenceXXXTest` classes to check for
`label()` accordingly. Updated CHANGELOG and upgrade docs.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1789
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/720.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #720
----
commit d6cb13e8fb1ff37b354d31cdc96aa5a765538e02
Author: Marko A. Rodriguez <[email protected]>
Date: 2017-09-21T19:23:15Z
Fixed a bug where ReferenceVertex was not returning label() (only
EMPTY_STRING). ReferenceEdge and ReferenceVertexProperty were behaving
correctly, but I needed to make a change at ReferenceElement for general
handling. Thus, those other two classes changed. And thus, the Gryo. I updated
all the ReferenceXXXTest classes to check for label() to be certain of proper
data handling. Updated CHANGELOG and upgrade docs.
commit acbc18ddc37a6a9453d672a0b4f64bcace9cf6cf
Author: Marko A. Rodriguez <[email protected]>
Date: 2017-09-21T19:31:18Z
In GraphComputer, labels of adjacent vertices can not be accessed. Thus,
ReferenceElement needs to ensure that label() doesn't throw an
UnsupportedOperationException. I borrowed the same technique used in
DeatchedElement.
----
> Reference elements should be represented by id and label
> --------------------------------------------------------
>
> Key: TINKERPOP-1789
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1789
> Project: TinkerPop
> Issue Type: Bug
> Components: io
> Affects Versions: 3.2.6
> Reporter: stephen mallette
> Assignee: Marko A. Rodriguez
> Priority: Critical
> Labels: breaking
> Fix For: 3.2.7, 3.3.1
>
>
> Reference elements don't have {{label()}} - wow. This is a breaking change
> because adding label to reference objects will mean that the gryo
> serialization format will change for reference objects.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
