[ 
https://issues.apache.org/jira/browse/TINKERPOP-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16176263#comment-16176263
 ] 

ASF GitHub Bot commented on TINKERPOP-1789:
-------------------------------------------

Github user robertdale commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/720#discussion_r140465221
  
    --- Diff: docs/src/upgrade/release-3.2.x-incubating.asciidoc ---
    @@ -95,6 +95,19 @@ In `gremlin-test` there is a new `GraphHelper` class 
that has a `cloneElements()
     the first graph to the second - `GraphHelper.cloneElements(Graph original, 
Graph clone)`. This helper method is
     primarily intended for use in tests.
     
    +Upgrading for Providers
    +~~~~~~~~~~~~~~~~~~~~~~~
    +
    +ReferenceVertex Label
    +^^^^^^^^^^^^^^^^^^^^^
    +
    +`ReferenceVertex.label()` was hard coded to return `EMPTY_STRING`. At some 
point, `ReferenceElements` were support to
    --- End diff --
    
    'to support'?


> Reference elements should be represented by id and label
> --------------------------------------------------------
>
>                 Key: TINKERPOP-1789
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1789
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: io
>    Affects Versions: 3.2.6
>            Reporter: stephen mallette
>            Assignee: Marko A. Rodriguez
>            Priority: Critical
>              Labels: breaking
>             Fix For: 3.2.7, 3.3.1
>
>
> Reference elements don't have {{label()}} - wow. This is a breaking change 
> because adding label to reference objects will mean that the gryo 
> serialization format will change for reference objects.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to