[
https://issues.apache.org/jira/browse/TINKERPOP-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317118#comment-16317118
]
ASF GitHub Bot commented on TINKERPOP-1861:
-------------------------------------------
GitHub user PBGraff opened a pull request:
https://github.com/apache/tinkerpop/pull/772
TINKERPOP-1861 Modify VertexProgram Builder to take varargs Graphs
VertexProgram.Builder.create() now takes varargs Graphs instead of just a
single Graph. This change has been propagated through all methods affected. Old
API is kept but deprecated for interfaces. Implementations of these interfaces
have been updated to use the new API. Possible test problems that I don't
understand and build flags due to API change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PBGraff/tinkerpop TINKERPOP-1861
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/772.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #772
----
commit 2a121f5a18385432c55000626114561a371ba138
Author: Graff, Philip B <philip.graff@...>
Date: 2018-01-08T21:26:05Z
First set of changes moving to new API
commit 48cb3dd3214050f7b54f16fa3576ec36f1196c49
Author: Graff, Philip B <philip.graff@...>
Date: 2018-01-08T20:22:48Z
Updates to keep old API but deprecated
commit ba2236dbfe85447265a8e56cabac46e419f665d1
Author: Graff, Philip B <philip.graff@...>
Date: 2018-01-08T21:16:34Z
Modifying the test
----
> VertexProgram create with varargs for Graphs
> --------------------------------------------
>
> Key: TINKERPOP-1861
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1861
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.2.7
> Reporter: Philip Graff
> Priority: Minor
>
> VertexProgram.Builder.create(Graph) can be modified to
> VertexProgram.Builder.create(Graph...) so that passing in zero or many graphs
> is naturally handled. The current state of passing in null when no graph is
> needed is bad practice.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
