[ https://issues.apache.org/jira/browse/TINKERPOP-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16321485#comment-16321485 ]
ASF GitHub Bot commented on TINKERPOP-1861: ------------------------------------------- Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/772#discussion_r160840507 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/computer/traversal/step/VertexComputing.java --- @@ -53,7 +53,19 @@ * @param memory the {@link Memory} from the previous OLAP job if it exists, else its an empty memory structure. * @return the generated vertex program instance. */ - public VertexProgram generateProgram(final Graph graph, final Memory memory); + @Deprecated --- End diff -- As noted above, the javadoc needs some entries given the deprecation. > VertexProgram create with varargs for Graphs > -------------------------------------------- > > Key: TINKERPOP-1861 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1861 > Project: TinkerPop > Issue Type: Improvement > Components: process > Affects Versions: 3.2.7 > Reporter: Philip Graff > Priority: Minor > > VertexProgram.Builder.create(Graph) can be modified to > VertexProgram.Builder.create(Graph...) so that passing in zero or many graphs > is naturally handled. The current state of passing in null when no graph is > needed is bad practice. -- This message was sent by Atlassian JIRA (v6.4.14#64029)