[
https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347574#comment-16347574
]
ASF GitHub Bot commented on TINKERPOP-1862:
-------------------------------------------
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/777
I just added the new toy graph infrastructure on #794 - as soon as that
merges then we can finish this one up.
@PBGraff something still sorta looks fishy here with the commit history. my
expectation would be that this PR would have no commits except your own, but i
still see some of mine (and others) in there. I don't know the full state of
your fork, so it's hard to give advice, but perhaps you need to:
1. update your fork's tp32 branch with the latest from tinkerpop
2. `git checkout tp32`
3. `git checkout -b TINKERPOP-1862-revised`
4. cherry pick just your commits from TINKERPOP-1862 over to
TINKERPOP-1862-revised
5. kill the old TINKERPOP-1862 (local and remote) and rename it
TINKERPOP-1862-revised appropriately by dropping the "-revised" then push that
Then going forward all you should have to do is keep your fork's tp32
branch updated and periodically: `git rebase origin/tp32` on the TINKERPOP-1862
branch which will continually take all your changes and replay them on the head
of your fork's tp32.
If you have some other more elegant git solution, that's cool too....just
providing the hammer solution to the problem in case you can't figure out
anything better.
> TinkerGraph VertexProgram message passing doesn't work properly when using
> Direction.BOTH
> -----------------------------------------------------------------------------------------
>
> Key: TINKERPOP-1862
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1862
> Project: TinkerPop
> Issue Type: Bug
> Components: process, tinkergraph
> Affects Versions: 3.2.7
> Reporter: Philip Graff
> Priority: Major
>
> I think the messages are being sent properly in TinkerMessenger, but when I
> call messenger.receiveMessages(), the vertex is getting messages from the
> outVertex of their edges regardless of the edge direction. This is due to
> line 71 of TinkerMessenger (linked below) which calls
> Edge.vertices(direction).next(), thus getting the first result out of the
> Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following
> line 124 of TinkerEdge (linked below), the outVertex is always returned
> first. TinkerMessenger needs to be modified to return the correct vertex (I
> think it's the one that != this.vertex).
> https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71
> https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
