[
https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376134#comment-16376134
]
ASF GitHub Bot commented on TINKERPOP-1862:
-------------------------------------------
GitHub user PBGraff opened a pull request:
https://github.com/apache/tinkerpop/pull/801
TINKERPOP-1862 TinkerMessenger proper handling of Direction.BOTH
New PR based off of #777 re-based on new head of tp32 branch. Need to
update toy graph merged in #794 with scenario for this test and then update
relevant tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PBGraff/tinkerpop TINKERPOP-1862
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/801.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #801
----
commit f02ea338a8d039c50896f7c65ca57a695975fc43
Author: Graff, Philip B <philip.graff@...>
Date: 2018-01-04T18:27:44Z
TinkerMessenger proper handling of Direction.BOTH
commit 80c0b8465fe9bb6ddbe4522a36304c7ba054e909
Author: Graff, Philip B <philip.graff@...>
Date: 2018-01-14T02:32:29Z
Adding simple graph computer test of proper message passing in all 3
directions
commit 750677cf55d7445c3746870d86c6592f6cd3664d
Author: Graff, Philip B <philip.graff@...>
Date: 2018-01-14T04:49:27Z
Test cleanup - hopefully can run now
commit 153238b2a8a3fc5e051251662ef6ab80f72c659f
Author: Graff, Philip B <philip.graff@...>
Date: 2018-01-14T06:01:17Z
Additional check. Tests still fail - but I think this is a problem with the
implementations, not the test.
commit 5467a33f2e17ad22b736effebede124556f049ed
Author: Graff, Philip B <philip.graff@...>
Date: 2018-01-14T18:44:33Z
Test bug fix and refactoring repeated code
----
> TinkerGraph VertexProgram message passing doesn't work properly when using
> Direction.BOTH
> -----------------------------------------------------------------------------------------
>
> Key: TINKERPOP-1862
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1862
> Project: TinkerPop
> Issue Type: Bug
> Components: process, tinkergraph
> Affects Versions: 3.2.7
> Reporter: Philip Graff
> Priority: Major
>
> I think the messages are being sent properly in TinkerMessenger, but when I
> call messenger.receiveMessages(), the vertex is getting messages from the
> outVertex of their edges regardless of the edge direction. This is due to
> line 71 of TinkerMessenger (linked below) which calls
> Edge.vertices(direction).next(), thus getting the first result out of the
> Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following
> line 124 of TinkerEdge (linked below), the outVertex is always returned
> first. TinkerMessenger needs to be modified to return the correct vertex (I
> think it's the one that != this.vertex).
> https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71
> https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
