[ https://issues.apache.org/jira/browse/TINKERPOP-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382108#comment-16382108 ]
ASF GitHub Bot commented on TINKERPOP-1862: ------------------------------------------- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/801 I'm sorry to say that spark integration tests are failing for your added tests. Not sure what's wrong. I made an initial fix that solved the first body of errors. I updated `ToyGraphInputRDD` to include: ```java else if (configuration.getString(Constants.GREMLIN_HADOOP_INPUT_LOCATION).contains("sink")) vertices = IteratorUtils.list(IteratorUtils.map(TinkerFactory.createKitchenSink().vertices(), VertexWritable::new)); ``` But the tests still fail with: ```text [ERROR] testMessagePassingOut(org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest) Time elapsed: 5.693 s <<< ERROR! java.util.concurrent.ExecutionException: java.lang.IllegalStateException: Name is null at org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.runMPTest(GraphComputerTest.java:2741) at org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.testMessagePassingOut(GraphComputerTest.java:2710) Caused by: java.lang.IllegalStateException: Name is null Caused by: java.lang.NullPointerException: Name is null [ERROR] testMessagePassingBoth(org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest) Time elapsed: 5.397 s <<< ERROR! java.util.concurrent.ExecutionException: java.lang.IllegalStateException: Name is null at org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.runMPTest(GraphComputerTest.java:2741) at org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.testMessagePassingBoth(GraphComputerTest.java:2726) Caused by: java.lang.IllegalStateException: Name is null Caused by: java.lang.NullPointerException: Name is null [ERROR] testMessagePassingIn(org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest) Time elapsed: 5.198 s <<< ERROR! java.util.concurrent.ExecutionException: java.lang.IllegalStateException: Name is null at org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.runMPTest(GraphComputerTest.java:2741) at org.apache.tinkerpop.gremlin.process.computer.GraphComputerTest.testMessagePassingIn(GraphComputerTest.java:2694) Caused by: java.lang.IllegalStateException: Name is null Caused by: java.lang.NullPointerException: Name is null ``` Not sure I know what is causing that....I don't what "Name" is referring to here. I was guessing the property you just added to "sink" but it's not the same case, so...... > TinkerGraph VertexProgram message passing doesn't work properly when using > Direction.BOTH > ----------------------------------------------------------------------------------------- > > Key: TINKERPOP-1862 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 > Project: TinkerPop > Issue Type: Bug > Components: process, tinkergraph > Affects Versions: 3.2.7 > Reporter: Philip Graff > Priority: Major > > I think the messages are being sent properly in TinkerMessenger, but when I > call messenger.receiveMessages(), the vertex is getting messages from the > outVertex of their edges regardless of the edge direction. This is due to > line 71 of TinkerMessenger (linked below) which calls > Edge.vertices(direction).next(), thus getting the first result out of the > Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following > line 124 of TinkerEdge (linked below), the outVertex is always returned > first. TinkerMessenger needs to be modified to return the correct vertex (I > think it's the one that != this.vertex). > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 > https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v7.6.3#76005)