Github user spmallette commented on the pull request:
https://github.com/apache/tinkerpop/commit/bccff988dc713b9acdee9e9a3858e2c10b7de163#commitcomment-28083988
In
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/Traversal.java:
In
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/Traversal.java
on line 431:
Could you please expand the comments here a bit? It would be nice to see
(1) A follow-on sentence in the javadoc that explains when this method should
be called (i.e. when a strategy modifies XyzStep and is applied post
AbcStrategy) (2) a comment (perhaps not javadoc, just something inline of the
method) that provides brief reminder as to the reason that you added this (i.e.
SubgraphStrategy tests were randomly failing because....)
---