Github user spmallette commented on the pull request:
https://github.com/apache/tinkerpop/commit/bccff988dc713b9acdee9e9a3858e2c10b7de163#commitcomment-28084039
In
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/decoration/SubgraphStrategy.java:
In
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/strategy/decoration/SubgraphStrategy.java
on line 182:
Could you please add an in-line comment here to outline the logic of why
invalidation is necessary? in the future, someone is going to be writing a
strategy and look for the only real usage of
`invalidateTraverserRequirements()` and it's just going to lead here. it would
be nice to have a clear explanation as an example that includes reasoning for
why this was necessary specifically in this case and how to apply it generally
to other cases - I'd think of this as the "reference implementation" for this
new method.
---
