Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/867
  
    Cool. A few comments/questions:
    
    1. sorry - you will need to rebase as i just updated dev docs and now this 
PR is conflicted
    2. I guess the Giraph failure doesn't matter - it seems like this change 
really couldn't have triggered that failure
    3. I feel like it would be good to add some user docs for the template, no? 
I do see that you have the README, but I think having something in those 
reference docs would be good to as that's easy to link to. Maybe add to this 
section: http://tinkerpop.apache.org/docs/3.2.9/reference/#gremlin-archetypes 
(probably should just rename that to "Application Templates" (leave the 
"gremlin-archetypes" anchor though)?  
    4. regarding " The Maven package now requires Mono when .NET should be 
built as it's not possible to pack dotnet templates without Nuget (dotnet pack 
doesn't work for this unfortunately)." do you just mean that the 
`dotnet-maven-plugin` call to `pack` doesn't work ( 
https://github.com/apache/tinkerpop/pull/867/files#diff-eb2d4cdb0a821b1a1e7166f54bc46d2aR87
 ) for templates?


---

Reply via email to