Github user FlorianHockmann commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/842#discussion_r188710881
--- Diff:
gremlin-dotnet/test/Gremlin.Net.UnitTest/Structure/IO/GraphSON/GraphSONReaderTests.cs
---
@@ -39,7 +39,13 @@ public class GraphSONReaderTests
private GraphSONReader CreateStandardGraphSONReader()
{
return new GraphSONReader();
- }
+ }
+
+ [Fact]
+ public void Assert_loaded_Newtonsoft_Json_version()
+ {
+ Assert.Equal(new Version(11, 0, 0, 0),
typeof(JToken).Assembly.GetName().Version);
--- End diff --
Ok, good point. But then I would suggest that you add a comment that
explains why version 11 is needed and maybe also change the test name to be
more in line with the other tests. How about something like
_NewtonsoftJsonVersionShouldSupportReallyBigIntegers_?
---
