[
https://issues.apache.org/jira/browse/TINKERPOP-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509749#comment-16509749
]
ASF GitHub Bot commented on TINKERPOP-967:
------------------------------------------
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/876
This PR shows a pretty nice level of understanding of the intricacies of
the core of how Gremlin works. We rarely get PRs that touch this area of
TinkerPop to any depth. I found it interesting that most of the plumbing for
this feature was already there. It mostly just needed a new `Traverser` species
in place to make it all come together.
I made a separate comment on this PR to expand a unit test case, but other
than that, it looks pretty good. As a minor nit, @GCHQResearcher1337 if you
could please make a second pass through your changes and `final` any variables
you see that can be marked as such (as that is our style).
@dkuppitz could you take a look at the Gremlin tests added here in detail
and see if you would recommend any others?
Anyway, that's my initial pass at this. I expect to give it a second look
before I provide my VOTE. I would also like to see feedback from @dkuppitz who
is on holiday until next week, so I probably won't have any other feedback
until then.
> Support nested-repeat() structures
> ----------------------------------
>
> Key: TINKERPOP-967
> URL: https://issues.apache.org/jira/browse/TINKERPOP-967
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.1.0-incubating
> Reporter: Marko A. Rodriguez
> Assignee: Marko A. Rodriguez
> Priority: Major
>
> All the internal plumbing is staged for this to happen, we just haven't gone
> all the way. In short, a {{NESTED_LOOP}} traverser has an internal
> {{loopStack}} where {{repeat(repeat())}} will have a {{loopStack}} of two.
> The {{it.loops()}} checks of the internal repeat will always check the top of
> the stack and when its done repeating will delete its counter off the top of
> the stack.
> [~dkuppitz]'s work on {{LoopStep}} will be backwards compatible. In
> {{RepeatStep}} we will support:
> {code}
> repeat('a',out('knows').repeat('b',out('parent')))
> {code}
> and thus, things like {{loops('a')}} as well as {{times('a',2)}}. Note that
> naming the loop stack will be a super rare case as most people will just
> assume standard nested looping semantics with a push/pop stack.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
