[
https://issues.apache.org/jira/browse/TINKERPOP-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519114#comment-16519114
]
ASF GitHub Bot commented on TINKERPOP-967:
------------------------------------------
Github user GCHQResearcher1337 commented on the issue:
https://github.com/apache/tinkerpop/pull/876
@spamallete I think I steered away from that because I initially
misunderstood what marko meant - as you pointed out the plumbing (`incrLoops`
taking a `stepLabel`) for nested repeats is already there, but I didn't find
any plumbing had been done for this (neither `times()` nor `loop()` can take a
`stepLabel`) so I thought that the 'work on `LoopStep`' had been abandoned.
Re-reading this I think I see what is involved and can implement this -
both `TimesModulating` and `LoopStep` as well as the `loops()` method of a
traverser need to be able to take a stepLabel. We would need to maintain a
separate user-defined stepLabel that could be accessed.
I can see why `loops('a')` could be helpful, but I don't know why you would
want to do `times('a',2)`. Could you please provide an example of this?
PS Hi Marko! Thanks for Gremlin!
> Support nested-repeat() structures
> ----------------------------------
>
> Key: TINKERPOP-967
> URL: https://issues.apache.org/jira/browse/TINKERPOP-967
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.1.0-incubating
> Reporter: Marko A. Rodriguez
> Assignee: Marko A. Rodriguez
> Priority: Major
>
> All the internal plumbing is staged for this to happen, we just haven't gone
> all the way. In short, a {{NESTED_LOOP}} traverser has an internal
> {{loopStack}} where {{repeat(repeat())}} will have a {{loopStack}} of two.
> The {{it.loops()}} checks of the internal repeat will always check the top of
> the stack and when its done repeating will delete its counter off the top of
> the stack.
> [~dkuppitz]'s work on {{LoopStep}} will be backwards compatible. In
> {{RepeatStep}} we will support:
> {code}
> repeat('a',out('knows').repeat('b',out('parent')))
> {code}
> and thus, things like {{loops('a')}} as well as {{times('a',2)}}. Note that
> naming the loop stack will be a super rare case as most people will just
> assume standard nested looping semantics with a push/pop stack.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
