Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/838#discussion_r195710841
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStep.java
---
@@ -273,11 +300,40 @@ public RepeatEndStep(final Traversal.Admin traversal)
{
super(traversal);
}
+ final LinkedList<Traverser.Admin<S>> stashedStarts = new
LinkedList<>();
--- End diff --
> Any thoughts on what might be some decent data/traversals for the
JFRs/microbenchmarks around this?
Maybe just start with the Grateful Dead dataset? I think it might be
sufficiently complex to yield a good test of the different approaches we have
now. If not, maybe we need to generate something artificial.
Personally, I'd love to see a JFR that executes the same traversal with
each of the three configurations that we now have with a `Thread.sleep()`
between them so that we can easily distinguish when one traversal stops and the
next starts. Not sure what the traversal (or traversals) needs to be - I guess
I'd just like to easily compare what happens from a processing/memory
perspective with each of the configurations we've talked about and then true
that up with the expectations that we have regarding each configuration that we
have.
> As far as OLAP goes, what are the expectations there?
I was just curious if it all the tests still pass there or not. I'd assume
so given that you didn't make changes there, but I just wanted to be sure.
---
