[
https://issues.apache.org/jira/browse/TINKERPOP-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533535#comment-16533535
]
stephen mallette commented on TINKERPOP-1998:
---------------------------------------------
Sorry - I don't quite follow the example you used with
{{shouldReadWriteModernToFileWithHelpers}} - could you explain this further:
> expects a different schema from the standard graph than from the readGraph,
> the latter attempts to create vertices in a (default) vertex collection
> instead of using the people or software ones that were used for the former.
Are you saying that the graph constructed as "readGraph" ends up with a
"default" vertex label somehow?
> It would also help, for graph technologies that require schemas, to have a
> document that describe the schemas used/expected in the tests.
Agreed. There shouldn't be a massive number of variations - we largely stick to
the standard toy graphs here:
https://github.com/apache/tinkerpop/blob/2fd11a1458ea274b2308d1a5863406c303537732/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerFactory.java
but there are a few variations from that where a particular test isn't well
represented by our standard data.
> I am collecting this information atm, but having to run failing tests to
> capture what label/edges I am missing for each test is a PITA.
If you could compile a list and where they are used that would be amazing. In
addition to adding that information to the provider documentation, I would
likely recommend that we try to collapse those variations down and possibly
push them into the "sink" data set:
https://github.com/apache/tinkerpop/blob/2fd11a1458ea274b2308d1a5863406c303537732/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerFactory.java#L182
Sorry that this part is a hassle and we appreciate the feedback. I think we'd
all greatly appreciate anything you can contribute back to make it easier.
Thanks.
> IoGraphTest use different schemas for standard and readGraph configurations
> ---------------------------------------------------------------------------
>
> Key: TINKERPOP-1998
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1998
> Project: TinkerPop
> Issue Type: Improvement
> Affects Versions: 3.3.0
> Reporter: Horacio Hoyos Rodriguez
> Priority: Minor
>
> In ArangoDB labels used by vertices and edges must be known in order to
> create a graph. As a result this information should be available at startup,
> i.e via configuration. For example _shouldReadWriteModernToFileWithHelpers_
> test expects a different schema from the *standard* graph than from the
> *readGraph*, the latter attempts to create vertices in a (default) vertex
> collection instead of using the people or software ones that were used for
> the former.
> It would also help, for graph technologies that require schemas, to have a
> document that describe the schemas used/expected in the tests. I am
> collecting this information atm, but having to run failing tests to capture
> what label/edges I am missing for each test is a PITA.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
