[
https://issues.apache.org/jira/browse/TINKERPOP-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16533847#comment-16533847
]
stephen mallette commented on TINKERPOP-1998:
---------------------------------------------
I still don't see how/where {{shouldReadWriteModernToFileWithHelpers}} requires
the default vertex label of "vertex" or the default edge label of "edge". That
test uses the "modern" graph which is defined here:
https://github.com/apache/tinkerpop/blob/2fd11a1458ea274b2308d1a5863406c303537732/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerFactory.java#L89
for all variations of the test (i.e. graphson/gryo versions and graphml). All
of those test use a known schema of vertex/edge labels from what i can see -
sorry, but what am i missing?
> I am writing all my findings on implementing the API and running the tests.
> Once I have managed to run most of them I will publish it somewhere and from
> there we can decide what is the best way to add it to the official docs.
+1 - again...appreciated
> {{GraphTest.shouldRemoveEdges}} ... what is the correct use of edge labels?
This test wasn't written to enforce a method demonstrating a real use case for
edge labels. I sense that it just wanted a bunch of unique edge labels.
But....i don't see how that is useful. We should probably fix that. I don't
like the use of "random" in tests so constructing random UUID there isn't so
good. We could change that to use a single edge label without hurting the
semantics of the test imo. good feedback.
> IoGraphTest use different schemas for standard and readGraph configurations
> ---------------------------------------------------------------------------
>
> Key: TINKERPOP-1998
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1998
> Project: TinkerPop
> Issue Type: Improvement
> Affects Versions: 3.3.0
> Reporter: Horacio Hoyos Rodriguez
> Priority: Minor
>
> In ArangoDB labels used by vertices and edges must be known in order to
> create a graph. As a result this information should be available at startup,
> i.e via configuration. For example _shouldReadWriteModernToFileWithHelpers_
> test expects a different schema from the *standard* graph than from the
> *readGraph*, the latter attempts to create vertices in a (default) vertex
> collection instead of using the people or software ones that were used for
> the former.
> It would also help, for graph technologies that require schemas, to have a
> document that describe the schemas used/expected in the tests. I am
> collecting this information atm, but having to run failing tests to capture
> what label/edges I am missing for each test is a PITA.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
