[
https://issues.apache.org/jira/browse/TINKERPOP-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16535323#comment-16535323
]
ASF GitHub Bot commented on TINKERPOP-1977:
-------------------------------------------
GitHub user mattallenuk opened a pull request:
https://github.com/apache/tinkerpop/pull/889
Tinkerpop 1977 - Sasl Authentication
Have implemented Sasl Authentication after discussion on Gremlin Users
group. I think this is along the lines of the thinking of the TINKERPOP-1977
(https://issues.apache.org/jira/browse/TINKERPOP-1977). Have added an
authenticator base class and implemented a SaslAuthenticator class on top of
that.
Have made modification to the DriverRemoteConnection class to accommodate
the authentication class. Have also moved UUID function into utils as used in
the SaslAuthenticator as well.
Tested changes on a local project worked great.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattallenuk/tinkerpop TINKERPOP-1977
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/889.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #889
----
commit 6aa4e98b7bfb23d432f1d00a0a9d5d79486ba80c
Author: Matthew Allen <matt.allen@...>
Date: 2018-07-06T19:49:54Z
Implementation of Sasl authentication.
commit c466f8af146ba20ff8e0787cb006efc4266a821a
Author: Matthew Allen <matt.allen@...>
Date: 2018-07-06T20:09:57Z
Added tests.
commit 791c0f844db2563db7c2e248a55c165cdb6bbe34
Author: Matthew Allen <matt.allen@...>
Date: 2018-07-06T20:12:16Z
Unsaved changes uploaded
----
> Gremlin-JavaScript: Support SASL authentication
> -----------------------------------------------
>
> Key: TINKERPOP-1977
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1977
> Project: TinkerPop
> Issue Type: Improvement
> Components: javascript
> Reporter: Jorge Bay
> Priority: Major
>
> We should add support for SASL authentication flow, ideally a generic
> interface and an implementation using username and password.
> An authenticator could have the following interface:
> {code:javascript}
> /** @abstract */
> class Authenticator {
> /**
> @returns {Promise} Returns a promise containing the Request to be sent.
> When the Promise resolves to a null value, it indicates that the
> authentication flow was successful.
> */
> evaluateChallenge(response) {
> throw new Error("evaluateChallenge should be implemented");
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
