[ 
https://issues.apache.org/jira/browse/TINKERPOP-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16588939#comment-16588939
 ] 

ASF GitHub Bot commented on TINKERPOP-1977:
-------------------------------------------

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/889
  
    hmm - something still looks fishy:
    
    https://github.com/mattallenuk/tinkerpop/commits/TINKERPOP-1977
    
    we should have a string of your continuous commits on top of `tp32` but 
they are instead interspersed with the other stuff. not sure how it got in that 
state. 
    
    let me think about how to `git` your way out of this and get the commit 
history clean.


> Gremlin-JavaScript: Support SASL authentication
> -----------------------------------------------
>
>                 Key: TINKERPOP-1977
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1977
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: javascript
>            Reporter: Jorge Bay
>            Priority: Major
>
> We should add support for SASL authentication flow, ideally a generic 
> interface and an implementation using username and password.
> An authenticator could have the following interface:
> {code:javascript}
> /** @abstract */
> class Authenticator {
>   /**
>   @returns {Promise} Returns a promise containing the Request to be sent.
>   When the Promise resolves to a null value, it indicates that the 
> authentication flow was successful.
>   */ 
>   evaluateChallenge(response) {
>     throw new Error("evaluateChallenge should be implemented");
>   }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to