[
https://issues.apache.org/jira/browse/TINKERPOP-967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541989#comment-16541989
]
ASF GitHub Bot commented on TINKERPOP-967:
------------------------------------------
Github user dkuppitz commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/876#discussion_r202114725
--- Diff:
gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatTest.java
---
@@ -386,5 +531,51 @@ public void
g_V_hasXname_markoX_repeatXoutE_inV_simplePathX_untilXhasXname_rippl
public Traversal<Vertex, Path>
get_g_V_hasXloop_name_loopX_repeatXinX_timesX5X_path_by_name() {
return
g.V().has("loops","name","loop").repeat(__.in()).times(5).path().by("name");
}
+
+ @Override
+ public Traversal<Vertex, Path>
get_g_V_repeatXout_repeatXoutX_timesX1XX_timesX1X_limitX1X_path_by_name() {
+ // NB We need to prevent the RepeatUnrollStrategy from
applying to properly exercise this test as this traversal can be simplified
+ return
g.V().repeat(out().repeat(out()).times(1)).times(1).limit(1).path().by("name");
+ }
+
+ @Override
+ public Traversal<Vertex, Path>
get_g_V_repeatXoutXknowsXX_untilXrepeatXoutXcreatedXX_emitXhasXname_lopXXX_path_byXnameX()
{
+ return
g.V().repeat(out("knows")).until(__.repeat(out("created")).emit(__.has("name",
"lop"))).path().by("name");
+ }
+
+ @Override
+ public Traversal<Vertex, String>
get_g_V_repeatXrepeatXout_createdXX_untilXhasXname_rippleXXXemit_lang() {
+ return
g.V().repeat(__.repeat(out("created")).until(__.has("name",
"ripple"))).emit().values("lang");
+ }
+
+ @Override
+ public Traversal<Vertex, String>
get_g_V_untilXconstantXtrueXX_repeatXrepeatXout_createdXX_untilXhasXname_rippleXXXemit_lang()
{
+ return
g.V().until(__.constant(true)).repeat(__.repeat(out("created")).until(__.has("name",
"ripple"))).emit().values("lang");
+ }
+
+ @Override
+ public Traversal<Vertex, String>
get_g_VX3X_repeatXbothX_createdXX_untilXloops_is_40XXemit_repeatXin_knowsXX_emit_loopsXisX1Xdedup_values(final
Object v3Id) {
+ return
g.V(v3Id).repeat(__.both("created")).until(loops().is(40)).emit(__.repeat(__.in("knows")).emit(loops().is(1))).dedup().values("name");
+ }
+
+ @Override
+ public Traversal<Vertex, String>
get_g_V_repeatXa_outXknows_repeatXb_outXcreatedX_filterXloops_isX0XX_emit_lang()
{
+ return g.V().repeat("a", out("knows").repeat("b",
out("created").filter(loops("a").is(0))).emit()).emit().values("lang");
+ }
+
+ @Override
+ public Traversal<Vertex, String>
get_g_V_emit_repeatXa_outXknows_filterXloops_isX0XX_lang() {
+ return g.V().emit().repeat("a",
out("knows").filter(loops("a").is(0))).values("lang");
+ }
+
+ @Override
+ public Traversal<Vertex, String>
get_g_VX6X_repeatXa_bothXcreatedXX_emitXrepeatXb_bothXknowsXX_untilXorXloops_isX2X_loopsXbX_isXloopsXaXXXX_hasXname_vadasXX_dedup_name(final
Object v6Id) {
+ return g.V(v6Id).repeat("a",
both("created")).emit(__.repeat("b",
__.both("knows")).until(__.or(loops().is(2),
loops("b").is(loops("a")))).has("name", "vadas")).dedup().values("name");
--- End diff --
See my comment in the asciidoc file (same query).
> Support nested-repeat() structures
> ----------------------------------
>
> Key: TINKERPOP-967
> URL: https://issues.apache.org/jira/browse/TINKERPOP-967
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.1.0-incubating
> Reporter: Marko A. Rodriguez
> Assignee: Marko A. Rodriguez
> Priority: Major
>
> All the internal plumbing is staged for this to happen, we just haven't gone
> all the way. In short, a {{NESTED_LOOP}} traverser has an internal
> {{loopStack}} where {{repeat(repeat())}} will have a {{loopStack}} of two.
> The {{it.loops()}} checks of the internal repeat will always check the top of
> the stack and when its done repeating will delete its counter off the top of
> the stack.
> [~dkuppitz]'s work on {{LoopStep}} will be backwards compatible. In
> {{RepeatStep}} we will support:
> {code}
> repeat('a',out('knows').repeat('b',out('parent')))
> {code}
> and thus, things like {{loops('a')}} as well as {{times('a',2)}}. Note that
> naming the loop stack will be a super rare case as most people will just
> assume standard nested looping semantics with a push/pop stack.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
