[GitHub] tinkerpop pull request #919: String loop to String builder

[robertdale]

Github user robertdale commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/919#discussion_r211934275
  
    --- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java
 ---
    @@ -286,10 +286,10 @@ private void appendMetrics(final Collection<? extends 
Metrics> metrics, final St
         private static String padLeft(final String text, final int 
amountToPad) {
             // not sure why this method needed to exist. stupid string format 
stuff and commons utilities wouldn't
             // work for some reason in the context this method was used above.
    -        String newText = text;
    +        final StringBuilder newText = new StringBuilder(text);
             for (int ix = 0; ix < amountToPad; ix++) {
    -            newText = " " + newText;
    +            newText.insert(0, " ");
             }
    --- End diff --
    
    Would it make sense to put this block before `text` then it won't have to 
do inserts?


---