[GitHub] tinkerpop pull request #919: String loop to String builder [master]

[robertdale]

Github user robertdale commented on a diff in the pull request:

    https://github.com/apache/tinkerpop/pull/919#discussion_r211948320
  
    --- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/util/DefaultTraversalMetrics.java
 ---
    @@ -208,14 +208,14 @@ private void handleNestedTraversals(final 
Traversal.Admin traversal, final Mutab
         private void appendMetrics(final Collection<? extends Metrics> 
metrics, final StringBuilder sb, final int indent) {
             // Append each StepMetric's row. indexToLabelMap values are 
ordered by index.
             for (Metrics m : metrics) {
    -            String rowName = m.getName();
    +            final StringBuilder metricName = new 
StringBuilder(m.getName());
     
                 // Handle indentation
                 for (int ii = 0; ii < indent; ii++) {
    -                rowName = "  " + rowName;
    +                metricName.insert(0, "  ");
                 }
    --- End diff --
    
    Yes, I get that. What I'm suggesting is that instead of having to `insert` 
data later on thus incurring the cost of array copies, why not put the 
indentation loop first, then everything after can be `append` only.


---