[
https://issues.apache.org/jira/browse/TINKERPOP-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638299#comment-16638299
]
ASF GitHub Bot commented on TINKERPOP-2056:
-------------------------------------------
GitHub user dkuppitz opened a pull request:
https://github.com/apache/tinkerpop/pull/949
TINKERPOP-2056 Use NumberHelper in Compare
Instead of converting all numbers to `BigDecimal`, `Compare` predicates now
use `NumberHelper` for numerical comparisons.
`docker/build.sh -t -i -n` passed.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-2056
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/949.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #949
----
commit 8759b39ce83b2165bc1415d1feead005e970a505
Author: Daniel Kuppitz <daniel_kuppitz@...>
Date: 2018-10-04T14:07:27Z
TINKERPOP-2056 Made use of `NumberHelper` in `Compare` predicates.
----
> Use NumberHelper in Compare
> ---------------------------
>
> Key: TINKERPOP-2056
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2056
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.2.9
> Reporter: Daniel Kuppitz
> Assignee: Daniel Kuppitz
> Priority: Major
>
> The {{Compare}} enum doesn't use {{NumberHelper}}. Instead, it converts
> numbers of differing types to {{BigDecimal}}s. That's pretty much the slowest
> thing we can do.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
