[
https://issues.apache.org/jira/browse/TINKERPOP-2056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639666#comment-16639666
]
ASF GitHub Bot commented on TINKERPOP-2056:
-------------------------------------------
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/949
Just pushed a commit 4bdb006c5ee418f27ef7bb8a9330714ce414c50f on the
release branches to deal with these pesky tests that sometimes fail in travis:
```text
[ERROR]
GremlinGroovyScriptEngineTest.shouldAllowsUseToBeExecutedAfterImport:293 »
Runtime
[ERROR]
GremlinGroovyScriptEngineTest.shouldLoadImportsViaDependencyManagerFromDependencyGatheredByUse:279
» Runtime
```
Obviously not related to this change. Did you happen to do any tests to see
what this optimization bought us in terms of performance?
VOTE +1
> Use NumberHelper in Compare
> ---------------------------
>
> Key: TINKERPOP-2056
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2056
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.2.9
> Reporter: Daniel Kuppitz
> Assignee: Daniel Kuppitz
> Priority: Major
>
> The {{Compare}} enum doesn't use {{NumberHelper}}. Instead, it converts
> numbers of differing types to {{BigDecimal}}s. That's pretty much the slowest
> thing we can do.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)