[
https://issues.apache.org/jira/browse/TINKERPOP-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16929503#comment-16929503
]
ASF GitHub Bot commented on TINKERPOP-1810:
-------------------------------------------
spmallette commented on pull request #1192: TINKERPOP-1810 Support for
withSack() that use Lambdas with remotes
URL: https://github.com/apache/tinkerpop/pull/1192
https://issues.apache.org/jira/browse/TINKERPOP-1810
To support this we needed to better detect the number of arguments that a
lambda has so that we can properly deserialize to BinaryOperator or
UnaryOperator. We also needed to better cast arguments for groovy given
withSack() overlaods that aren't easily detected during eval() and generate
errors otherwise. The method for detecting arguments isn't super nice - just
some string parsing, but since Gremlin really only ever expects zero, one or
two arg lambdas the risk of taking this approach seems low. Note that users who
want to distinguish arguments must specify them with a full groovy closure
syntax or else it will assume "unknown" as it always has.
All tests pass with `docker/build.sh -t -i`
VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add Lambda.binaryOperator and Lambda.unaryOperator
> --------------------------------------------------
>
> Key: TINKERPOP-1810
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1810
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
> Affects Versions: 3.2.6
> Reporter: Ted Wilmes
> Assignee: stephen mallette
> Priority: Major
>
> While working with sack and lambdas, I found that I could not specify a split
> ({{UnaryOperator}}) or merge ({{BinaryOperator}}) operator remotely using the
> {{Lambda}} class helper methods. The sack supplier worked without issue
> because we already have {{Lambda.supplier}}. I propose we add
> {{Lambda.unaryOperator}} and {{Lambda.binaryOperator}}.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
