[
https://issues.apache.org/jira/browse/TINKERPOP-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17510698#comment-17510698
]
ASF GitHub Bot commented on TINKERPOP-2716:
-------------------------------------------
spmallette commented on a change in pull request #1582:
URL: https://github.com/apache/tinkerpop/pull/1582#discussion_r832344998
##########
File path: gremlin-javascript/pom.xml
##########
@@ -236,6 +236,16 @@ file.write(file.getText("UTF-8").replaceFirst(/"version":
"(.*)",/, "\"version\"
<failOnError>true</failOnError>
</configuration>
</execution>
+ <execution>
+ <id>npm lint</id>
+ <phase>lint</phase>
Review comment:
it needs to be a valid maven phase and "lint" is not one of those. you
would want to probably tie this to the "verify" phase which would happen after
integration tests. something like:
```xml
<execution>
<id>npm test</id>
<phase>verify</phase>
<goals>
<goal>npm</goal>
</goals>
<configuration>
<skip>${skipTests}</skip>
<arguments>run lint</arguments>
<failOnError>true</failOnError>
</configuration>
</execution>
```
not sure if `run lint` needs other flags to exit out nicely in
maven....you'll have to test but at least you hopefully see the pattern now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enable eslint for gremlin-javascript project
> --------------------------------------------
>
> Key: TINKERPOP-2716
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2716
> Project: TinkerPop
> Issue Type: Improvement
> Components: javascript
> Affects Versions: 3.5.2
> Reporter: Tom Kolanko
> Priority: Minor
>
> The gremlin-javascript project has no linter set so it's easy for code to be
> formatted differently depending on the editor used to save the changes
> From https://github.com/apache/tinkerpop/pull/1539#discussion_r818682368 we
> can implement eslint + airbnb's config to have a standard which editors would
> be able to pick up
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
