[
https://issues.apache.org/jira/browse/TINKERPOP-2716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511103#comment-17511103
]
ASF GitHub Bot commented on TINKERPOP-2716:
-------------------------------------------
FlorianHockmann commented on a change in pull request #1582:
URL: https://github.com/apache/tinkerpop/pull/1582#discussion_r832988557
##########
File path: gremlin-javascript/pom.xml
##########
@@ -236,6 +236,16 @@ file.write(file.getText("UTF-8").replaceFirst(/"version":
"(.*)",/, "\"version\"
<failOnError>true</failOnError>
</configuration>
</execution>
+ <execution>
+ <id>npm lint</id>
+ <phase>lint</phase>
Review comment:
> you would want to probably tie this to the "verify" phase which would
happen after integration tests
Wouldn't it make more sense to let a linter run before executing costly
integration tests? If my code isn't formatted correctly, I wouldn't want to
wait after all integration tests were executed to get that information, only so
I can change the formatting and then having to execute all integration tests
again to see whether the linter is now happy.
How about tying this to the `validate` phase instead which happens first and
[the
docs](https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html#a-build-lifecycle-is-made-up-of-phases)
describe it as:
> validate the project is correct and all necessary information is available
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Enable eslint for gremlin-javascript project
> --------------------------------------------
>
> Key: TINKERPOP-2716
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2716
> Project: TinkerPop
> Issue Type: Improvement
> Components: javascript
> Affects Versions: 3.5.2
> Reporter: Tom Kolanko
> Priority: Minor
>
> The gremlin-javascript project has no linter set so it's easy for code to be
> formatted differently depending on the editor used to save the changes
> From https://github.com/apache/tinkerpop/pull/1539#discussion_r818682368 we
> can implement eslint + airbnb's config to have a standard which editors would
> be able to pick up
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
