[
https://issues.apache.org/jira/browse/TINKERPOP-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17637450#comment-17637450
]
ASF GitHub Bot commented on TINKERPOP-2480:
-------------------------------------------
cole-bq commented on code in PR #1838:
URL: https://github.com/apache/tinkerpop/pull/1838#discussion_r1029806753
##########
docs/src/dev/provider/index.asciidoc:
##########
@@ -848,6 +848,14 @@ Server returns for a single request. Again, this
description of Gremlin Server'
out-of-the-box configuration. It is quite possible to construct other flows,
that might be more amenable to a
particular language or style of processing.
+It is recommended but not required that a driver include a `User-Agent` header
as part of any web socket
Review Comment:
How much value do you see in having such a benchmark? My understanding is
that the jmh benchmarks aren't currently setup for measuring anything like the
driver handshake latency. I also have concerns about how usefulness of any
result as the latency will be highly dependent on network conditions. A typical
user agent in the format we are using is under 100 bytes and it is only sent
once per connection in the handshake. Personally I don't foresee there being
any noticeable side effects other than the obvious added logging and metrics.
Some sort of benchmark can certainty be added but I don't believe it will be
trivial to add and I worry it won't offer much value for the investment put
into creating it.
> User agent for Gremlin drivers
> ------------------------------
>
> Key: TINKERPOP-2480
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2480
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver, server
> Affects Versions: 3.4.8
> Reporter: Divij Vaidya
> Priority: Minor
>
> Currently, a server does not distinguish amongst the different types of
> clients connecting to it. This issue is to add a new feature to add user
> agent field in the HTTP and WebSocket request header which could be used to
> identify the specific client from which the request was made.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
