[
https://issues.apache.org/jira/browse/TINKERPOP-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631012#comment-17631012
]
ASF GitHub Bot commented on TINKERPOP-2480:
-------------------------------------------
spmallette commented on code in PR #1838:
URL: https://github.com/apache/tinkerpop/pull/1838#discussion_r1017823259
##########
gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/Cluster.java:
##########
@@ -993,6 +1002,16 @@ public Builder connectionSetupTimeoutMillis(final long
connectionSetupTimeoutMil
return this;
}
+ /**
+ * Configures whether cluster will send a user agent during
+ * web socket handshakes
+ * @param enableUserAgentOnConnect true enables the useragent. false
disables the useragent.
+ */
+ public Builder enableUserAgentOnConnect(boolean
enableUserAgentOnConnect) {
+ this.wsHandshakeUserAgentEnabled = enableUserAgentOnConnect;
Review Comment:
it seems like you went with the rename i suggested - please rename the
underlying variables as well to keep things consistent.
nit: `final`
> User agent for Gremlin drivers
> ------------------------------
>
> Key: TINKERPOP-2480
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2480
> Project: TinkerPop
> Issue Type: Improvement
> Components: driver, server
> Affects Versions: 3.4.8
> Reporter: Divij Vaidya
> Priority: Minor
>
> Currently, a server does not distinguish amongst the different types of
> clients connecting to it. This issue is to add a new feature to add user
> agent field in the HTTP and WebSocket request header which could be used to
> identify the specific client from which the request was made.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
