[
https://issues.apache.org/jira/browse/TINKERPOP-2824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17692825#comment-17692825
]
ASF GitHub Bot commented on TINKERPOP-2824:
-------------------------------------------
vkagamlyk commented on code in PR #1843:
URL: https://github.com/apache/tinkerpop/pull/1843#discussion_r1116070627
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/GremlinScriptChecker.java:
##########
@@ -34,15 +34,16 @@ public class GremlinScriptChecker {
/**
* An empty result whose properties return as empty.
*/
- public static final Result EMPTY_RESULT = new Result(null, null);
+ public static final Result EMPTY_RESULT = new Result(null, null, null);
/**
* At least one of these tokens should be present somewhere in the Gremlin
string for {@link #parse(String)} to
* take any action at all.
*/
+ // todo: why not used `Tokens`?
Review Comment:
added in
https://github.com/apache/tinkerpop/pull/1843/commits/8c36b01b673982875d9d9e04d91f3ddce73860f5
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/jsr223/GremlinScriptChecker.java:
##########
@@ -162,7 +168,10 @@ public class GremlinScriptChecker {
* </pre>
*/
private static final Pattern patternWithOptions =
- Pattern.compile("\\.with\\(((?:" + timeoutTokens +
"),(?<to>\\d*)(:?L|l)?)|((?:" + requestIdTokens +
"),[\"'](?<rid>.*?))[\"']\\)");
+ Pattern.compile("\\.with\\((((?:"
Review Comment:
Benchmark Mode Cnt
Score Error Units
GremlinScriptCheckerBenchmark.testParseAll thrpt 20
203909.105 ± 8915.473 ops/s
GremlinScriptCheckerBenchmark.testParseMaterializeProperties thrpt 20
484647.497 ± 15267.578 ops/s
GremlinScriptCheckerBenchmark.testParseRequestId thrpt 20
382702.687 ± 6140.784 ops/s
> Properties on Elements
> ----------------------
>
> Key: TINKERPOP-2824
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2824
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet, driver, go, javascript, process, python
> Affects Versions: 3.5.4
> Reporter: Valentyn Kahamlyk
> Assignee: Valentyn Kahamlyk
> Priority: Major
>
> Problem: When a user writes `g.V()` they get back a Vertex object. The
> problem is that depending on the execution context of the traversal, the
> result could be quite different, with or without properties.
> Solution: Implement new finalization strategy DetachStrategy(detachMode,
> properties) where mode is one of ALL, NONE or CUSTOM. `properties` is list of
> properties name, are taken into account only for CUSTOM mode.
> Discussion thread in dev list: [Proposal to handle properties on response
> Elements-Apache Mail
> Archives|https://lists.apache.org/thread/l8rw7ydj7kym8vhtwk50nhbp45ng9986]
> Stephen's thread in dev list: [The Issue of Detachment-Apache Mail
> Archives|https://lists.apache.org/thread/xltcon4zxnwq4fyw2r2126syyrqm8spy]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
