[
https://issues.apache.org/jira/browse/TINKERPOP-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17747715#comment-17747715
]
ASF GitHub Bot commented on TINKERPOP-2951:
-------------------------------------------
Cole-Greer commented on PR #2160:
URL: https://github.com/apache/tinkerpop/pull/2160#issuecomment-1652818438
Hi Itay,
Thanks for all the rapid changes to the PR. To build off of Valentyn’s
comments once again, I think there are still additional types that will need to
be supported in order for the translator to be considered complete. Support for
the following will all be needed:
- Translation of nested structures (within lists and maps)
- Primitive types (Char, Byte/int8, Short/int16)
- More common structure types (Date, Datetime, UUID, BigInteger, BigDecimal)
- Strategies
The [python
translator](https://github.com/apache/tinkerpop/blob/master/gremlin-python/src/main/python/gremlin_python/process/translator.py)
is a good reference to follow for this.
There is still an opportunity for this to be merged tomorrow morning
(Thursday in the Americas) if its complete although the release process is
already well underway so this would be the final chance to make it into the
upcoming release. If there is only minor tweaks needed tomorrow morning we may
be able to assist with getting it finished up and into the release.
Thanks,
Cole
> Add translator to the Go GLV
> ----------------------------
>
> Key: TINKERPOP-2951
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2951
> Project: TinkerPop
> Issue Type: Improvement
> Components: go
> Affects Versions: 3.5.6, 3.6.4
> Reporter: Valentyn Kahamlyk
> Priority: Major
>
> Currently there is no equivalent to GroovyTranslator for the Go client. There
> are Translator's in all other GLV's. Adding one for the Go client will
> further help in moving all the clients to a consistent level of
> functionality.
> https://tinkerpop.apache.org/docs/current/reference/#translators
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
