[
https://issues.apache.org/jira/browse/TINKERPOP-2951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17759330#comment-17759330
]
ASF GitHub Bot commented on TINKERPOP-2951:
-------------------------------------------
itaywol commented on PR #2213:
URL: https://github.com/apache/tinkerpop/pull/2213#issuecomment-1694597145
> @itaywol Looks like your new changes broke one of the new tests:
>
> ```
> gremlin-go-integration-tests | ❌
Test_translator_Translate/g.withStrategies(new_PartitionStrategy(includeMetaProperties:false,partitionKey:'partition',writePartition:'a',readPartitions:['a'])).addV('test')
(0s)
> gremlin-go-integration-tests | translator_test.go:676:
translator.Translate() = g.withStrategies(new
PartitionStrategy(readPartitions:['a'],includeMetaProperties:false,partitionKey:'partition',writePartition:'a')).addV('test'),
equals g.withStrategies(new
PartitionStrategy(includeMetaProperties:false,partitionKey:'partition',writePartition:'a',readPartitions:['a'])).addV('test')
> ```
>
> Seems like the order of the arguments to `new PartitionStrategy` are
getting shuffled for some reason. However both the expected and actual output
for this test are semantically equivalent as we are dealing with named
parameters in this case.
FYI
https://stackoverflow.com/questions/55925822/why-are-iterations-over-maps-random
I would implement a logic in the test to check equality even for random
order.
Will update it today !
> Add translator to the Go GLV
> ----------------------------
>
> Key: TINKERPOP-2951
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2951
> Project: TinkerPop
> Issue Type: Improvement
> Components: go
> Affects Versions: 3.5.6, 3.6.4
> Reporter: Valentyn Kahamlyk
> Priority: Major
>
> Currently there is no equivalent to GroovyTranslator for the Go client. There
> are Translator's in all other GLV's. Adding one for the Go client will
> further help in moving all the clients to a consistent level of
> functionality.
> https://tinkerpop.apache.org/docs/current/reference/#translators
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
