[
https://issues.apache.org/jira/browse/TINKERPOP-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768348#comment-17768348
]
ASF GitHub Bot commented on TINKERPOP-2423:
-------------------------------------------
codecov-commenter commented on PR #2254:
URL: https://github.com/apache/tinkerpop/pull/2254#issuecomment-1732509115
##
[Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2254?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
> Merging
[#2254](https://app.codecov.io/gh/apache/tinkerpop/pull/2254?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(eca3508) into
[3.6-dev](https://app.codecov.io/gh/apache/tinkerpop/commit/8acfcb188144b302ac8aebcd813cdf6a18beb2c8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
(8acfcb1) will **decrease** coverage by `4.05%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 3.6-dev #2254 +/- ##
=============================================
- Coverage 75.23% 71.18% -4.05%
=============================================
Files 1054 25 -1029
Lines 63294 3766 -59528
Branches 6913 0 -6913
=============================================
- Hits 47617 2681 -44936
+ Misses 13112 898 -12214
+ Partials 2565 187 -2378
```
[see 1029 files with indirect coverage
changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2254/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
> hashCode collision for steps with different attributes
> ------------------------------------------------------
>
> Key: TINKERPOP-2423
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2423
> Project: TinkerPop
> Issue Type: Bug
> Components: process
> Affects Versions: 3.4.8
> Reporter: Saikiran Boga
> Priority: Major
>
> The {{hashCode computation}} for PropertiesStep collides for multiple steps
> when there are repeating keys. For example {{.properties()}} and
> {{.properties("a","a")}}, {{.properties("a")}} and
> .{{properties("a","b","b")}} have the same hash code because of xor of just
> properties here
> [https://github.com/apache/tinkerpop/blob/cff4c161615f2b50bda27b6ba523c7f52b833532/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/map/PropertiesStep.java#L80-L87].
> Basically, the even keys cancel out the xor computation.
>
> The same is also true for {{AbstractStep.hashCode}} which takes xor of labels.
> {{GraphStep}} does the same thing using ids. so {{g.V("1", "1")}} and
> {{g.V()}} would collide during comparison.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
