[
https://issues.apache.org/jira/browse/TINKERPOP-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17776605#comment-17776605
]
ASF GitHub Bot commented on TINKERPOP-2995:
-------------------------------------------
spmallette commented on code in PR #2298:
URL: https://github.com/apache/tinkerpop/pull/2298#discussion_r1363646423
##########
gremlin-driver/src/main/java/example/Example.java:
##########
@@ -0,0 +1,157 @@
+/*
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+*/
+
+package example;
+
+// Common imports
+import org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal;
+import
org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversalSource;
+
+import static
org.apache.tinkerpop.gremlin.process.traversal.AnonymousTraversalSource.traversal;
+import static org.apache.tinkerpop.gremlin.process.traversal.P.*;
+import static org.apache.tinkerpop.gremlin.structure.T.*;
+import static org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__.*;
+
+import org.apache.tinkerpop.gremlin.driver.Client;
+import org.apache.tinkerpop.gremlin.driver.Cluster;
+import org.apache.tinkerpop.gremlin.driver.remote.DriverRemoteConnection;
+import org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__;
+import org.apache.tinkerpop.gremlin.structure.Edge;
+import org.apache.tinkerpop.gremlin.structure.Graph;
+import org.apache.tinkerpop.gremlin.structure.Vertex;
+import org.apache.tinkerpop.gremlin.structure.io.AbstractIoRegistry;
+import org.apache.tinkerpop.gremlin.structure.io.IoRegistry;
+import org.apache.tinkerpop.gremlin.structure.io.binary.TypeSerializerRegistry;
+import org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerFactory;
+import org.apache.tinkerpop.gremlin.tinkergraph.structure.TinkerGraph;
+import org.apache.tinkerpop.gremlin.util.MessageSerializer;
+import org.apache.tinkerpop.gremlin.util.ser.GraphBinaryMessageSerializerV1;
+
+import java.lang.reflect.Array;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+public class Example {
+
+ public static void main(String[] args) throws Exception {
+ connectionExample();
+ basicGremlinExample();
+ modernTraversalExample();
+ }
+
+ public static void connectionExample() throws Exception {
Review Comment:
i like that this is showing different ways to connect, but is it confusing
that "g" is just being reassigned over and over again? `g.close()` only
releases resources on the last "g" - maybe folks might misuse this example as a
pattern for creating "g" somehow? maybe not a big deal for an example i guess.
the C# version only uses one initialization of "g" and comments the other out.
perhaps this java example should work this way too?
> Create Sample Applications in each GLV
> --------------------------------------
>
> Key: TINKERPOP-2995
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2995
> Project: TinkerPop
> Issue Type: Improvement
> Components: dotnet, go, javascript, python
> Affects Versions: 3.5.7
> Reporter: Yang Xia
> Priority: Major
>
> It would be great to have working example applications for each GLV, with
> basic traversal examples and common connection settings.
> Currently we have an `example.py` for python, but it is very minimal. There
> is also an `example.go` for golang, but that appears to be outdated. As far
> as I know, dotnet only has templates and javascript doesn't have any examples
> at all.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
