[ 
https://issues.apache.org/jira/browse/TINKERPOP-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17777904#comment-17777904
 ] 

ASF GitHub Bot commented on TINKERPOP-2995:
-------------------------------------------

Cole-Greer commented on code in PR #2299:
URL: https://github.com/apache/tinkerpop/pull/2299#discussion_r1367367916


##########
gremlin-dotnet/example/example.csproj:
##########
@@ -0,0 +1,14 @@
+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <OutputType>Exe</OutputType>
+    <TargetFramework>net7.0</TargetFramework>
+    <ImplicitUsings>enable</ImplicitUsings>
+    <Nullable>enable</Nullable>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <PackageReference Include="Gremlin.Net" Version="3.7.0" />

Review Comment:
   There may be some trickery which can be done by configuring multiple 
instances of dependabot to run in each branch along with some rules to restrict 
the version in each branch. That would still require the committer to be 
careful when merging those commits up to other branches to preserve the correct 
version. If we consider it essential to have the example versions align with 
the latest release in each respective branch, this might be best left as an 
additional administrative task for release managers. It may be possible to use 
the Maven Replacer Plugin to automatically this version with every `mvn 
compile` but the same caution around merging between branches would apply.
   
   Personally I'm somewhat indifferent to how/if the versions should be 
maintained here. The main value I see in these examples is demonstrating basic 
driver setup, connection, and querying. This has remained relatively constant 
over the last few major releases and I think that a 3.7.x example is still 
useful for someone attempting to use 3.6.x.





> Create Sample Applications in each GLV
> --------------------------------------
>
>                 Key: TINKERPOP-2995
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2995
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: dotnet, go, javascript, python
>    Affects Versions: 3.5.7
>            Reporter: Yang Xia
>            Priority: Major
>
> It would be great to have working example applications for each GLV, with 
> basic traversal examples and common connection settings. 
> Currently we have an `example.py` for python, but it is very minimal. There 
> is also an `example.go` for golang, but that appears to be outdated. As far 
> as I know, dotnet only has templates and javascript doesn't have any examples 
> at all. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to