[
https://issues.apache.org/jira/browse/TINKERPOP-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781454#comment-17781454
] ASF GitHub Bot commented on TINKERPOP-2996: ------------------------------------------- codecov-commenter commented on PR #2316: URL: https://github.com/apache/tinkerpop/pull/2316#issuecomment-1787554798 ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2316?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report > Merging [#2316](https://app.codecov.io/gh/apache/tinkerpop/pull/2316?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4b324f5) into [3.6-dev](https://app.codecov.io/gh/apache/tinkerpop/commit/3f1f28df102b151bc62cadd83c3cee8b154236df?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3f1f28d) will **increase** coverage by `0.00%`. > The diff coverage is `100.00%`. ```diff @@ Coverage Diff @@ ## 3.6-dev #2316 +/- ## ========================================== Coverage 75.15% 75.15% Complexity 12290 12290 ========================================== Files 1056 1056 Lines 63371 63379 +8 Branches 6924 6924 ========================================== + Hits 47628 47635 +7 - Misses 13179 13182 +3 + Partials 2564 2562 -2 ``` | [Files](https://app.codecov.io/gh/apache/tinkerpop/pull/2316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [...process/traversal/translator/GolangTranslator.java](https://app.codecov.io/gh/apache/tinkerpop/pull/2316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90aW5rZXJwb3AvZ3JlbWxpbi9wcm9jZXNzL3RyYXZlcnNhbC90cmFuc2xhdG9yL0dvbGFuZ1RyYW5zbGF0b3IuamF2YQ==) | `46.32% <100.00%> (+5.27%)` | :arrow_up: | | [gremlin-go/driver/traversal.go](https://app.codecov.io/gh/apache/tinkerpop/pull/2316?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z3JlbWxpbi1nby9kcml2ZXIvdHJhdmVyc2FsLmdv) | `75.53% <100.00%> (+1.10%)` | :arrow_up: | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2316/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) > Golang Translator in core does not properly translate list arguments > -------------------------------------------------------------------- > > Key: TINKERPOP-2996 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2996 > Project: TinkerPop > Issue Type: Bug > Components: go > Affects Versions: 3.7.0, 3.5.7, 3.6.5 > Reporter: Yang Xia > Priority: Critical > > Currently for the bytecode translatro in core, all list type arguments are > translated as varargs for golang, instead of proper list type like > []interface{}{}. > Currently this is causing errors in certain translations, i.e. g.inject([1, > 2]) is being translated to g.Inject(1, 2), but some investigation will be > needed to tease apart cases that may need a varargs argument. -- This message was sent by Atlassian Jira (v8.20.10#820010)
