[ 
https://issues.apache.org/jira/browse/TINKERPOP-2996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17781551#comment-17781551
 ] 

ASF GitHub Bot commented on TINKERPOP-2996:
-------------------------------------------

xiazcy commented on PR #2316:
URL: https://github.com/apache/tinkerpop/pull/2316#issuecomment-1788169741

   LGTM VOTE +1. Just a note to whoever merges this, since we are changing the 
generated feature file with the translation, might need to regenerate it up the 
branch. 




> Golang Translator in core does not properly translate list arguments
> --------------------------------------------------------------------
>
>                 Key: TINKERPOP-2996
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2996
>             Project: TinkerPop
>          Issue Type: Bug
>          Components: go
>    Affects Versions: 3.7.0, 3.5.7, 3.6.5
>            Reporter: Yang Xia
>            Priority: Critical
>
> Currently for the bytecode translatro in core, all list type arguments are 
> translated as varargs for golang, instead of proper list type like 
> []interface{}{}.
> Currently this is causing errors in certain translations, i.e. g.inject([1, 
> 2]) is being translated to g.Inject(1, 2), but some investigation will be 
> needed to tease apart cases that may need a varargs argument. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to