[
https://issues.apache.org/jira/browse/TINKERPOP-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852830#comment-17852830
]
ASF GitHub Bot commented on TINKERPOP-3028:
-------------------------------------------
vkagamlyk commented on code in PR #2640:
URL: https://github.com/apache/tinkerpop/pull/2640#discussion_r1629728583
##########
gremlin-python/src/main/python/gremlin_python/process/graph_traversal.py:
##########
@@ -2236,6 +2243,10 @@ def r_trim(*args):
return __.r_trim(*args)
+def r_trim(*args):
Review Comment:
and one more duplicate `r_trim` definition
##########
gremlin-python/src/main/python/gremlin_python/process/graph_traversal.py:
##########
@@ -2112,6 +2116,9 @@ def l_trim(*args):
return __.l_trim(*args)
+def l_trim(*args):
Review Comment:
one more duplicate `l_trim` definition
> Convert translators to make use of the grammar
> ----------------------------------------------
>
> Key: TINKERPOP-3028
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3028
> Project: TinkerPop
> Issue Type: Improvement
> Components: translator
> Affects Versions: 3.6.6
> Reporter: Stephen Mallette
> Assignee: Stephen Mallette
> Priority: Major
>
> {{Translator}} infrastructure uses bytecode and reflection which has a number
> of technical imperfections and exemptions for it to work properly. Switching
> to the grammar for translation simplifies the code, removes friction and
> complexity when generating GLV tests, and should perform better. The focus
> for this issue is the Java series of translators which are relied on quite
> heavily.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
