[
https://issues.apache.org/jira/browse/TINKERPOP-3028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852973#comment-17852973
]
ASF GitHub Bot commented on TINKERPOP-3028:
-------------------------------------------
Cole-Greer commented on PR #2640:
URL: https://github.com/apache/tinkerpop/pull/2640#issuecomment-2153654347
Thanks for all of the work on this, it is a big step forward to have modern
gremlin-lang based translators.
I primarily focused my review on the Go and JS translators here as it is a
big PR and hard to capture everything at once. Prior to the release of TP4, I
would like to add some tests to ensure successful translation of some of the
more obscure literals, however I think that can be out of scope for this PR as
the new translators are at least as well tested as the old ones.
VOTE +1
> Convert translators to make use of the grammar
> ----------------------------------------------
>
> Key: TINKERPOP-3028
> URL: https://issues.apache.org/jira/browse/TINKERPOP-3028
> Project: TinkerPop
> Issue Type: Improvement
> Components: translator
> Affects Versions: 3.6.6
> Reporter: Stephen Mallette
> Assignee: Stephen Mallette
> Priority: Major
>
> {{Translator}} infrastructure uses bytecode and reflection which has a number
> of technical imperfections and exemptions for it to work properly. Switching
> to the grammar for translation simplifies the code, removes friction and
> complexity when generating GLV tests, and should perform better. The focus
> for this issue is the Java series of translators which are relied on quite
> heavily.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
