[
https://issues.apache.org/jira/browse/TINKERPOP-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17902740#comment-17902740
]
ASF GitHub Bot commented on TINKERPOP-2959:
-------------------------------------------
spmallette commented on code in PR #2919:
URL: https://github.com/apache/tinkerpop/pull/2919#discussion_r1868216598
##########
spark-gremlin/src/test/java/org/apache/tinkerpop/gremlin/spark/SparkGraphFeatureIntegrateTest.java:
##########
@@ -162,6 +162,11 @@ private static Map<String, Object>
getBaseConfiguration(final GraphData graphDat
put(Constants.SPARK_KRYO_REGISTRATION_REQUIRED, true);
}};
}
+
+ @Override
+ public boolean useParametersLiterally() {
+ return false;
Review Comment:
as noted for TinkerGraph, I feel like we need to test both configurations
because we want to test `GValue` (when this is "false") and straight
translation (when this is "true"). feels like we're leaving something out by
not having both configurations.
> Allow the grammar to support parameters
> ---------------------------------------
>
> Key: TINKERPOP-2959
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2959
> Project: TinkerPop
> Issue Type: Improvement
> Components: language
> Affects Versions: 3.6.4
> Reporter: Stephen Mallette
> Assignee: Stephen Mallette
> Priority: Major
> Fix For: 3.7.0
>
>
> Allow the grammar to support parameters similar to how the groovy engine does
> like, {{g.inject(x,y,z)}}. Doing this will make it easier for a transition
> away from the groovy engine as a lot of Gremlin in the world today uses
> parameters. The grammar may have to come with some limitations though as
> groovy is wide open in terms of what can be treated as a variable. Probably
> going to keep parameters tied to primitives, collections and tokens/enums
> like {{Order}} and {{Scope}}. Collections themselves will not contain
> parameters and things like a {{Traversal}} or {{P}} cannot be treated as one.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
