[
https://issues.apache.org/jira/browse/TINKERPOP-2959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17902825#comment-17902825
]
ASF GitHub Bot commented on TINKERPOP-2959:
-------------------------------------------
Cole-Greer commented on code in PR #2919:
URL: https://github.com/apache/tinkerpop/pull/2919#discussion_r1868690669
##########
neo4j-gremlin/src/test/java/org/apache/tinkerpop/gremlin/neo4j/Neo4jGraphFeatureTest.java:
##########
@@ -50,7 +50,7 @@
@RunWith(Cucumber.class)
@CucumberOptions(
- tags = "not @RemoteOnly and not @MultiProperties and not
@MetaProperties and not @GraphComputerOnly and not @AllowNullPropertyValues and
not @UserSuppliedVertexPropertyIds and not @UserSuppliedEdgeIds and not
@UserSuppliedVertexIds and not @TinkerServiceRegistry",
+ tags = "not @RemoteOnly and not @MultiProperties and not
@MetaProperties and not @GraphComputerOnly and not @AllowNullPropertyValues and
not @UserSuppliedVertexPropertyIds and not @UserSuppliedEdgeIds and not
@UserSuppliedVertexIds and not @TinkerServiceRegistry and not @StepHasId",
Review Comment:
There are 2 scenarios which are currently failing with Neo4j
(`g_V_hasIdXemptyX_count` and `g_V_hasIdXwithinXemptyXX_count`). Neo4j appears
to be letting all vertices pass with `hasId([])` whereas TinkerGraph is
filtering all vertices. I opted to ignore in this case as TinkerGraph is
working as expected, and the future of Neo4j-gremlin is up in the air at the
moment.
> Allow the grammar to support parameters
> ---------------------------------------
>
> Key: TINKERPOP-2959
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2959
> Project: TinkerPop
> Issue Type: Improvement
> Components: language
> Affects Versions: 3.6.4
> Reporter: Stephen Mallette
> Assignee: Stephen Mallette
> Priority: Major
> Fix For: 3.7.0
>
>
> Allow the grammar to support parameters similar to how the groovy engine does
> like, {{g.inject(x,y,z)}}. Doing this will make it easier for a transition
> away from the groovy engine as a lot of Gremlin in the world today uses
> parameters. The grammar may have to come with some limitations though as
> groovy is wide open in terms of what can be treated as a variable. Probably
> going to keep parameters tied to primitives, collections and tokens/enums
> like {{Order}} and {{Scope}}. Collections themselves will not contain
> parameters and things like a {{Traversal}} or {{P}} cannot be treated as one.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
