[
https://issues.apache.org/jira/browse/TINKERPOP-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928214#comment-17928214
]
ASF GitHub Bot commented on TINKERPOP-2966:
-------------------------------------------
andreachild commented on code in PR #3039:
URL: https://github.com/apache/tinkerpop/pull/3039#discussion_r1960663089
##########
gremlin-groovy/src/test/java/org/apache/tinkerpop/gremlin/groovy/jsr223/GremlinGroovyScriptEngineTest.java:
##########
@@ -515,7 +515,7 @@ public void shouldProduceBindingsForVars() throws Exception
{
assertThat(bytecodeBindings.containsKey("two"), is(true));
assertThat(bytecodeBindings.containsKey("three"), is(true));
-
assertEquals("g.V(v1Id).has('person','age',29).has('person','active',x).in_('knows').merge_e(m1).merge_v(m2).option(Merge.on_create,m3).merge_v(__.identity()).choose(__.out().count()).option(two,__.name).option(three,__.age).filter_(__.outE().count().is_(y)).map(l).order().by('name',o)",
gremlinAsPython);
+
assertEquals("g.V(v1Id).has('person','age',29).has('person','active',x).in_('knows').merge_e(m1).merge_v(m2).option(Merge.on_create,m3).merge_v(__.identity()).choose(__.out().count()).option(two,__.name).option(three,__.age).filter_(__.out_e().count().is_(y)).map(l).order().by('name',o)",
gremlinAsPython);
Review Comment:
I don't think this should have been changed as it's groovy not python.
> Change PythonTranslator to generate underscore based step naming
> ----------------------------------------------------------------
>
> Key: TINKERPOP-2966
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2966
> Project: TinkerPop
> Issue Type: Improvement
> Components: translator
> Affects Versions: 3.5.6
> Reporter: Stephen Mallette
> Priority: Minor
>
> The more idiomatic underscore based step naming was introduced a long time
> ago but the {{PythonTranslator}}} still produces the old camelcase style.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
