[
https://issues.apache.org/jira/browse/TINKERPOP-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928495#comment-17928495
]
ASF GitHub Bot commented on TINKERPOP-2966:
-------------------------------------------
andreachild commented on code in PR #3039:
URL: https://github.com/apache/tinkerpop/pull/3039#discussion_r1962013380
##########
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/translator/PythonTranslator.java:
##########
@@ -455,20 +451,12 @@ static final class SymbolHelper {
TO_PYTHON_MAP.put("is", "is_");
TO_PYTHON_MAP.put("list", "list_");
TO_PYTHON_MAP.put("max", "max_");
- TO_PYTHON_MAP.put("mergeE", "merge_e");
- TO_PYTHON_MAP.put("mergeV", "merge_v");
- TO_PYTHON_MAP.put("inV", "in_v");
- TO_PYTHON_MAP.put("outV", "out_v");
- TO_PYTHON_MAP.put("onCreate", "on_create");
- TO_PYTHON_MAP.put("onMatch", "on_match");
TO_PYTHON_MAP.put("min", "min_");
TO_PYTHON_MAP.put("or", "or_");
TO_PYTHON_MAP.put("not", "not_");
TO_PYTHON_MAP.put("range", "range_");
TO_PYTHON_MAP.put("set", "set_");
TO_PYTHON_MAP.put("sum", "sum_");
- TO_PYTHON_MAP.put("toLower", "to_lower");
- TO_PYTHON_MAP.put("toUpper", "to_upper");
TO_PYTHON_MAP.put("with", "with_");
//
TO_PYTHON_MAP.forEach((k, v) -> FROM_PYTHON_MAP.put(v, k));
Review Comment:
The removals of entries from the `TO_PYTHON_MAP` also affect the
`FROM_PYTHON_MAP` which affects the `toJava` method. It doesn't look like the
`toJava` method is actually used so both the `toJava` method and
`FROM_PYTHON_MAP` should be removed.
> Change PythonTranslator to generate underscore based step naming
> ----------------------------------------------------------------
>
> Key: TINKERPOP-2966
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2966
> Project: TinkerPop
> Issue Type: Improvement
> Components: translator
> Affects Versions: 3.5.6
> Reporter: Stephen Mallette
> Priority: Minor
>
> The more idiomatic underscore based step naming was introduced a long time
> ago but the {{PythonTranslator}}} still produces the old camelcase style.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
